Hello John,
Thanks for this serie, a few remarks below. > +(define-public libbpf > + (let* ((commit "6a1615c263b679c17ecb292fa897f159e826dc10")) Why using a specific commit? > + (package > + (name "libbpf") > + (version "0.0.8") The "0.0.9" is out there :) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/libbpf/libbpf";) > + (commit commit))) (commit (string-append "v" version)) should work fine. > + ("pkg-config" ,pkg-config) This should be a native-input, don't forget to run the linter :) > + (string-append "PREFIX=''") > + (string-append "DESTDIR=" (assoc-ref %outputs "out")) > + (string-append > + "CC=" (assoc-ref %build-inputs "gcc") "/bin/gcc")) This will put libraries in "lib64" directory which is not desired. You can set LIBDIR to "/lib" to avoid that. > + (chdir "src") I'm not sure this is needed. > + #t))))) > + (home-page "https://github.com/libbpf/libbpf";) > + (synopsis "BPF CO-RE (Compile Once – Run Everywhere)") > + (description > + "Libbpf supports building BPF CO-RE-enabled applications, which, in > +contrast to BCC, do not require Clang/LLVM runtime being deployed to target > +servers and does not rely on kernel-devel headers being available.") "kernel-devel" is more Debian specific I think. I'm also not sure that the "Clang deploying" things applied well to Guix. Thanks, Mathieu
