Forum: CFEngine Help
Subject: Re: COPBL fix for Solaris package_method
Author: jblaine
Link to topic: https://cfengine.com/forum/read.php?3,23613,23707#msg-23707
My post is a very minor suggestion to tweak what exists in the COPBL.
Your solution is much more complete, complex, and probably "more right".
Anything you can abstract, test, and make available in the COPBL with copious
comments would probably be very welcome by the CFEngine folks.
As an aside, in your linked post, you have an error (perhaps from
cutting/pasting):
"zone_lockfile_checked" expression =>
regcmp("$(lockfile_is_checked)","yes");
"zone_lockfile_exist" not => regcmp("$(lockfile)","");
I'm pretty sure $(lockfile_is_checked) and $(lockfile) need zone_ prepended to
the scalar names.
As another aside, because sometimes it takes another set of eyes to look at
code to see something (but perhaps you'll disagree with the idea): you could
change 'lockfile' everywhere to 'lock' and get your lines a little shorter
without hindering clarity at all.
Nice work.
_______________________________________________
Help-cfengine mailing list
Help-cfengine@cfengine.org
https://cfengine.org/mailman/listinfo/help-cfengine
