On 19/06/2020 00:13, Akim Demaille wrote:
> Hi Daniele,
>
>> Le 18 juin 2020 à 19:20, Akim Demaille <a...@lrde.epita.fr> a écrit :
>>
>>> However I have a ton of tests that expect the lexer to emit a
>>> "LEX_ERROR" token on error and I am considering to use YYerror special
>>> token to report errors instead. Thus the question if I can rename
>>> YYerror from "error" to "LEX_ERROR".
>>>
>>> The fix is rather easy:
>>>
>>> const char* token_name(int token)
>>> {
>>> if (token == YYerror)
>>> return "LEX_ERROR";
>>> return yysymbol_name(YYTRANSLATE(token));
>>> }
>>
>> It looks reasonable.
>
> Actually, why do you check the token name rather than the token kind itself?
Don't ask me, I didn't write the tests :)
The tests are written in Python (as most of the application). It may be
that when they were written it was deemed easier to emit the token names
from the lexer rather than export an enum mapping token names to token
kinds.
Cheers,
Dan
