URL: <https://savannah.gnu.org/bugs/?62620>
Summary: crypto plugin & client 4.0 not running Project: GNU Health Submitter: gerald_wiese Submitted: Mon 13 Jun 2022 12:44:14 PM UTC Category: None Severity: 3 - Normal Item Group: None Status: None Privacy: Public Assigned to: None Open/Closed: Open Release: None Discussion Lock: Any Module: gnuhealth client _______________________________________________________ Follow-up Comments: ------------------------------------------------------- Date: Mon 13 Jun 2022 12:44:14 PM UTC By: Gerald Wiese <gerald_wiese> Hey, I spent some time getting the crypto plugin running inside the 4.0 client. The main problem was that the folder 'tryton' in client 3.8 was renamed to 'gnuhealth' in client 4.0. Since crypto plugin did not change since 3.6 it was still trying to import from 'tryton' instead of 'gnuhealth' and the errors didn't appear in the logs. There are a few questions & problems: - Shouldn't the folder in the PyPI package 'gnuhealth-client' be 'gnuhealth_client' or something instead of 'gnuhealth' since there is a PyPI package 'gnuhealth'? - For Crypto plugin at least those imports should be fixed and released as 4.0.x. Maybe an alternative way of downloading an archive could be provided as well? PyPI? - In client in gnuhealth/plugins/__init__.py 'GH_PLUGINS_DIR' is not used anymore even though it is still defined in gnuhealth/config.py - For loading modules in gnuhealth/plugins/__init__.py exceptions should at least be printed, this was really painful to find the problem if nothing is printed after an error even in debug mode. So after 'except ImportError:' there should at least be some debug output instead of just 'continue'. - When the crypto plugin is working and I click on the gear for actions, the options for signing and verifying documents appear twice. I guess once is enough? ;) Best Gerald _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?62620> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/