looks like there is some inability of maven to handle the double invocation where the manifest LICENSE.txt is built by copying in /LICENSE-binary
I've just checked and this happens on branch 1.2.0 as well (64b6721). So it is not a regression, just a way for the build process to fail. because its not a regression, I don't think its a blocker. but we should mention it in our release notes about how to build this - arm64 doesn't work - you can't do package and install at the same tiime. Doesn't "mvn package" do an install first? I get confused here On Thu, 22 Aug 2024 at 02:36, slfan1989 <slfan1...@apache.org> wrote: > I encountered some issues while trying to compile with version > hadoop-thirdparty-1.3.0-RC1. > > Using mvn package clean -DskipTests succeeds in compiling, but using mvn > install package -DskipTests fails to compile. > > mvn clean package -DskipTests > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary for Apache Hadoop Third-party Libs 1.3.0: > [INFO] > [INFO] Apache Hadoop Third-party Libs ..................... SUCCESS [ > 0.862 s] > [INFO] Apache Hadoop shaded Protobuf ...................... SUCCESS [ > 1.521 s] > [INFO] Apache Hadoop shaded Guava ......................... SUCCESS [ > 1.027 s] > [INFO] Apache Hadoop shaded Avro 1.11 ..................... SUCCESS [ > 0.408 s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 4.261 s > [INFO] Finished at: 2024-08-22T09:32:46+08:00 > [INFO] > ------------------------------------------------------------------------ > > mvn install package -DskipTests > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (shade-protobuf) on > project hadoop-shaded-protobuf_3_25: Error creating shaded jar: duplicate > entry: META-INF/LICENSE.txt -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, > please read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > [ERROR] > [ERROR] After correcting the problems, you can resume the build with the > command > [ERROR] mvn <args> -rf :hadoop-shaded-protobuf_3_25 > > > Shilun Fan. > > On Thu, Aug 22, 2024 at 9:07 AM Mukund Madhav Thakur > > +1 ( binding) > > > > On Tue, Aug 20, 2024 at 9:16 AM Steve Loughran > > wrote: > > > > > Mukund and I have built a release candidate (RC1) for Hadoop-Thirdparty > > > 1.3.0. > > > > > > The RC is available at: > > > > > > https://dist.apache.org/repos/dist/dev/hadoop/hadoop-thirdparty-1.3.0-RC1/ > > > > > > The git tag is release-1.3.0-RC1, commit > > > 0fd62903b071b5186f31b7030ce42e1c00f6bb6a > > > > > > The maven artifacts are staged at > > > > https://repository.apache.org/content/repositories/orgapachehadoop-1420/ > > > > > > We've already been using the snapshot artifacts on hadoop trunk for the > > > protobuf update for a while, so we know that bit seems good. > > > Once this release is out we can adopt it in the 3.4.1 release (for > better > > > java 8 compatibility as well as updates). > > > > > > I have created a hadoop PR for the switch > > > https://github.com/apache/hadoop/pull/7007 > > > > > > This also updates the (transitive) binary license. The latest patch > also > > > tries to update docker to the same version of protoc -which hasn't been > > > done until now. Let's see what happens. > > > > > > Please try the release and vote. The vote will run for 5 days. > > > > > > Here is my vote: > > > > > > +1 (binding) > > > > > > > >
