lei w created HDFS-16052:
----------------------------
Summary: Remove variable inProgressTailingEnabled in
QuorumJournalManager
Key: HDFS-16052
URL: https://issues.apache.org/jira/browse/HDFS-16052
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: lei w
{code:java}
if (inProgressOk && inProgressTailingEnabled) {
// ....
try {
Collection<EditLogInputStream> rpcStreams = new ArrayList<>();
selectRpcInputStreams(rpcStreams, fromTxnId, onlyDurableTxns);
streams.addAll(rpcStreams);
return;
} catch (IOException ioe) {
//...
}
}
{code}
As shown above , tails edits via rpc is controlled by variables inProgressOk
and inProgressTailingEnabled. The variable inProgressTailingEnabled determined
by the configuration item “dfs.ha.tail-edits.in-progress” has some redundancy
here. Because variable inProgressOk is from a specific boolean value or
determined by the configuration item "dfs.ha.tail-edits.in-progress" too. My
understanding is that if inProgressOk is true, we can get the Editlog via RPC.
If we acqure Editlog failed via RPC or inProgressOk is false, we will execute
it according to the original logic. Can we only keep the variable inProgressOk
or add a new configuration item to determine whether tail edits via RPC?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
