Narges Shadab created HDFS-15791:
------------------------------------

             Summary: Possible Resource Leak
                 Key: HDFS-15791
                 URL: https://issues.apache.org/jira/browse/HDFS-15791
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: namenode
            Reporter: Narges Shadab


We noticed a possible resource leak 
[here|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java#L271].
 If an I/O error occurs at line 
[273|https://github.com/apache/hadoop/blob/06a5d3437f68546207f18d23fe527895920c756a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java#L273]
 or 
[277|https://github.com/apache/hadoop/blob/06a5d3437f68546207f18d23fe527895920c756a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java#L277],
 {{fin}} remains open since the exception isn't caught locally, and there is no 
way for any caller to close the FileInputStream

I'll submit a pull request to fix it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to