xuzq created HDFS-15769:
---------------------------
Summary: Metric metadataOperationRate maybe incorrect
Key: HDFS-15769
URL: https://issues.apache.org/jira/browse/HDFS-15769
Project: Hadoop HDFS
Issue Type: Bug
Reporter: xuzq
`metadataOperationRate` maybe incorrect with the wrong latency in
`addFileIoError`.
Because `begin` maybe 0 in `onFailure` when this FileIo not be sampled.
Code like:
{code:java}
// begin maybe 0 if this FileIo not be sampled.
public void onFailure(@Nullable FsVolumeSpi volume, long begin) {
if (isEnabled) {
DataNodeVolumeMetrics metrics = getVolumeMetrics(volume);
if (metrics != null) {
metrics.addFileIoError(Time.monotonicNow() - begin);
}
}
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
