Janus Chow created HDFS-15579:
---------------------------------
Summary: RBF: The constructor of PathLocation may got some
misunderstanding
Key: HDFS-15579
URL: https://issues.apache.org/jira/browse/HDFS-15579
Project: Hadoop HDFS
Issue Type: Improvement
Components: rbf
Reporter: Janus Chow
There is a constructor of PathLocation as follows, it's for creating a new
PathLocation with a prioritised nsId.
{code:java}
public PathLocation(PathLocation other, String firstNsId) {
this.sourcePath = other.sourcePath;
this.destOrder = other.destOrder;
this.destinations = orderedNamespaces(other.destinations, firstNsId);
}
{code}
When I was reading the code of MultipleDestinationMountTableResolver, I thought
this constructor was to create a PathLocation with an override destination. It
took me a while before I realize this is a constructor to sort the destinations
inside.
Maybe I think this constructor can be more clear about its usage?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
