Attila Doroszlai created HDDS-2505: -------------------------------------- Summary: Fix logic related to SCM address calculation in HddsUtils Key: HDDS-2505 URL: https://issues.apache.org/jira/browse/HDDS-2505 Project: Hadoop Distributed Data Store Issue Type: Bug Components: SCM Reporter: Attila Doroszlai Assignee: Attila Doroszlai
{{HddsUtils}} has 3 methods to calculate SCM address for various client types. All have an unreachable {{if}} branch, because: # {{iterator().next()}} throws exception for empty list # {{getSCMAddresses}} never returns empty list anyway, it throws exception * https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPX&open=AW5md-4qKcVY8lQ4ZsPX * https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPY&open=AW5md-4qKcVY8lQ4ZsPY * https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPW&open=AW5md-4qKcVY8lQ4ZsPW Ideally code duplication among these methods should be reduced, too. * https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPU&open=AW5md-4qKcVY8lQ4ZsPU * https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPT&open=AW5md-4qKcVY8lQ4ZsPT * https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPV&open=AW5md-4qKcVY8lQ4ZsPV Complete list of issues in the same file: https://sonarcloud.io/project/issues?fileUuids=AW5md-HhKcVY8lQ4Zrjn&id=hadoop-ozone&resolved=false -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org