fapifta opened a new pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95 ## What changes were proposed in this pull request? The PR aims to remove the isUseRatis(), getType(), and getFactor methods from the XCeiverClientManager class, as the return values of these methods are dependent on a single configuration value (ScmConfigKeys.DFS_CONTAINER_RATIS_ENABLED_KEY). The proposed solution moves the setup of the ContainerOperationClient setup to its constructor, with that the ContainerOperationClient class will be responsible to set up its internally used SCMClient, and XCeiverClientManager based on the configuration. It also gets responsible to set up the container size limit based on the configuration, and it is not being set anymore via a static method. To deal with the change, and to provide an easy way to get the values in JUnit tests, SCMTestUtil gets two new pubic static utility methods to get the ReplicationType, and ReplicationFactor based on the configuration. All accesses of the old methods on XCeiverClientManager are mapped to the new static utility methods. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-2373 - Move isUseRatis getFactor and getType from XCeiverClientManager ## How was this patch tested? As this is a refactoring without changing any outer logic, no new JUnit tests are needed, but all existent tests has to pass as before.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
