ChenSammi commented on a change in pull request #29: HDDS-2034. Async RATIS
pipeline creation and destroy through heartbeat commands
URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r339421360
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/block/TestBlockManager.java
##########
@@ -355,10 +364,9 @@ public void testBlockAllocationWithNoAvailablePipelines()
pipelineManager.finalizeAndDestroyPipeline(pipeline, false);
}
Assert.assertEquals(0, pipelineManager.getPipelines(type, factor).size());
- Assert.assertNotNull(blockManager
+ Assert.assertNull(blockManager
Review comment:
This TestBlockManager test doesn't use MiniOzoneCluster to do the test.
There is no hearbeats send by datanode. So when BlockManager.allocateBlock
sends out pipeline creation command, it will never receive the confirmation
from datanode. The new pipeline will always be in ALLOCATED state untill
timeout.
Unit tests which leverages MiniOzoneCluster don't have this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
