bharatviswa504 opened a new pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71 …quests. ## What changes were proposed in this pull request? OMVolumeCreateRequest.java L159: omClientResponse = new OMVolumeCreateResponse(omVolumeArgs,volumeList, omResponse.build()); We add this to double-buffer, and double-buffer flushThread which is running in the background when picks up, converts to protoBuf and to ByteArray and write to rocksDB tables. So, during this conversion(This conversion will be done without any lock acquire), if any other request changes internal structure(like acls list) of OmVolumeArgs we might get ConcurrentModificationException. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-2344 Please replace this section with the link to the Apache JIRA) ## How was this patch tested? Ran TestOzoneRpcClient which tests this code path and also added a new test for clone method.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
