hanishakoneru commented on a change in pull request #9: HDDS-2240. Command line
tool for OM Admin
URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r336278859
##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -139,7 +140,8 @@ message OMRequest {
optional MultipartUploadListPartsRequest listMultipartUploadPartsRequest =
50;
optional ServiceListRequest serviceListRequest =
51;
- optional DBUpdatesRequest dbUpdatesRequest =
53;
+ optional OMServerRolesRequest omServerRolesRequest =
52;
+ optional DBUpdatesRequest dbUpdatesRequest =
53;
Review comment:
The client connects to an OM and submits a getServiceList request. If this
OM is not the leader, then the client tries a different OM. This all happens
through _OMFailoverProxyProvider_.
Currently, the _getServiceList_ API is only used to discover the SCM
address. It does not return the list of OMs in the cluster.
But based on which OM serves the getServiceList request, we can presume it
to be the leader. We do not need a new request type. I will update the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
