Doroszlai, Attila created HDDS-2155: ---------------------------------------
Summary: Fix checkstyle errors Key: HDDS-2155 URL: https://issues.apache.org/jira/browse/HDDS-2155 Project: Hadoop Distributed Data Store Issue Type: Bug Affects Versions: 0.5.0 Reporter: Doroszlai, Attila Assignee: Doroszlai, Attila Checkstyle CI check have been providing false negative result recently, so some checkstyle violations have crept in. {noformat} hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/cache/TableCache.java <error line="88" severity="error" message="Line is longer than 80 characters (found 91)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/RocksDBStoreIterator.java <error line="29" severity="error" message="Line is longer than 80 characters (found 90)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> <error line="46" severity="error" message="Line is longer than 80 characters (found 105)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/LevelDBStoreIterator.java <error line="28" severity="error" message="Line is longer than 80 characters (found 90)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/utils/TestMetadataStore.java <error line="124" severity="error" message="Line is longer than 80 characters (found 87)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java <error line="451" column="11" severity="error" message="'}' at column 11 should be alone on a line." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/> hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/HddsClientUtils.java <error line="136" severity="error" message="Line is longer than 80 characters (found 89)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> <error line="144" severity="error" message="Line is longer than 80 characters (found 81)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> <error line="154" severity="error" message="Line is longer than 80 characters (found 99)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/S3KeyGenerator.java <error line="22" column="8" severity="error" message="Unused import - org.apache.hadoop.hdds.conf.OzoneConfiguration." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyValidator.java <error line="25" column="8" severity="error" message="Unused import - org.apache.hadoop.ozone.client.OzoneBucket." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SameKeyReader.java <error line="25" column="8" severity="error" message="Unused import - org.apache.hadoop.ozone.client.OzoneBucket." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/web/utils/OzoneUtils.java <error line="148" severity="error" message="Line is longer than 80 characters (found 89)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneFsShell.java <error line="20" column="8" severity="error" message="Unused import - java.io.IOException." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="21" column="8" severity="error" message="Unused import - java.io.PrintStream." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="22" column="8" severity="error" message="Unused import - java.util.ArrayList." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="23" column="8" severity="error" message="Unused import - java.util.Arrays." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="24" column="8" severity="error" message="Unused import - java.util.LinkedList." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="27" column="8" severity="error" message="Unused import - org.apache.hadoop.conf.Configured." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="29" column="8" severity="error" message="Unused import - org.apache.hadoop.fs.shell.Command." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="32" column="8" severity="error" message="Unused import - org.apache.hadoop.security.UserGroupInformation." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="33" column="8" severity="error" message="Unused import - org.apache.hadoop.tools.TableListing." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="34" column="8" severity="error" message="Unused import - org.apache.hadoop.tracing.TraceUtils." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="35" column="8" severity="error" message="Unused import - org.apache.hadoop.util.StringUtils." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="36" column="8" severity="error" message="Unused import - org.apache.hadoop.util.Tool." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="38" column="8" severity="error" message="Unused import - org.apache.htrace.core.TraceScope." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="39" column="8" severity="error" message="Unused import - org.apache.htrace.core.Tracer." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="40" column="8" severity="error" message="Unused import - org.slf4j.Logger." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="41" column="8" severity="error" message="Unused import - org.slf4j.LoggerFactory." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/> <error line="54" column="25" severity="error" message="'{' at column 25 should have line break after." source="com.puppycrawl.tools.checkstyle.checks.blocks.LeftCurlyCheck"/> <error line="61" column="43" severity="error" message="'{' at column 43 should have line break after." source="com.puppycrawl.tools.checkstyle.checks.blocks.LeftCurlyCheck"/> <error line="77" severity="error" message="First sentence should end with a period." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck"/> <error line="82" column="38" severity="error" message="Array brackets at illegal position." source="com.puppycrawl.tools.checkstyle.checks.ArrayTypeStyleCheck"/> {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org