Bharat Viswanadham created HDDS-1761:
----------------------------------------
Summary: Fix class hierarchy for OMKeyCreateRequest and
OMFileCreateRequest
Key: HDDS-1761
URL: https://issues.apache.org/jira/browse/HDDS-1761
Project: Hadoop Distributed Data Store
Issue Type: Sub-task
Reporter: Bharat Viswanadham
The patch looks mostly fine to me. A few minor comments. -and one type error
that needs to be fixed.-
I would like to see the class hierarchy refactored in a follow up patch.
{{OMFileCreateRequest}}should not extend {{OMKeyCreateRequest}}. Instead they
should both extend an abstract class that encapsulates the common functionality.
Generally deriving from _concrete_ classes is a bad idea.
This Jira is created based on [~arp] comment during review of HDDS-1731
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
