Elek, Marton created HDDS-1128:
----------------------------------
Summary: Create stateful manager class for the pipeline creation
scheduling
Key: HDDS-1128
URL: https://issues.apache.org/jira/browse/HDDS-1128
Project: Hadoop Distributed Data Store
Issue Type: Bug
Reporter: Elek, Marton
HDDS-1076 introduced a new static variable in RatisPipelineProvider: Scheduler.
It seems to be a global variable which makes the testing harder.
[~shashikant] also suggested to remove it:
{quote}It would be a good idea to move the scheduler Class Utility into some
common utility package so that it can be used in multiple places as and when
needed.
{quote}
I agree. And findbug also complains about it:
{quote}H D ST: Write to static field
org.apache.hadoop.hdds.scm.pipeline.RatisPipelineProvider.scheduler from
instance method new
org.apache.hadoop.hdds.scm.pipeline.RatisPipelineProvider(NodeManager,
PipelineStateManager, Configuration) At RatisPipelineProvider.java:[line 56]
{quote}
I think we need a new class which includes both the state of
RatisPipelineUtils.isPipelineCreatorRunning and
RaitsPipelineProvider.Scheduler. It should have one instance which is available
for the classes which requires it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
