+1 (non-binding) from me
I've been a part of the development of this feature throughout its existence, and have reviewed most of the code committed to the branch. The implementation has been conducted carefully and thoughtfully, and tested at a variety of sites. This feature has no potential negative impact if not enabled, so it does not present a risk to those who do not with to use it. I'm very much looking forward to seeing this be merged, and seeing how its usage can help to enable the community to scale the RPC workload of HDFS beyond what it can support today. Erik ________________________________ From: Zhe Zhang <z...@apache.org> Sent: Saturday, December 15, 2018 8:26:14 AM To: Konstantin Shvachko Cc: Hadoop Common; hdfs-dev; mapreduce-...@hadoop.apache.org; yarn-...@hadoop.apache.org Subject: Re: [VOTE - 2] Merge HDFS-12943 branch to trunk - Consistent Reads from Standby +1 Thanks for addressing concerns from the previous vote. On Fri, Dec 14, 2018 at 6:24 PM Konstantin Shvachko <shv.had...@gmail.com> wrote: > Hi Hadoop developers, > > I would like to propose to merge to trunk the feature branch HDFS-12943 for > Consistent Reads from Standby Node. The feature is intended to scale read > RPC workloads. On large clusters reads comprise 95% of all RPCs to the > NameNode. We should be able to accommodate higher overall RPC workloads (up > to 4x by some estimates) by adding multiple ObserverNodes. > > The main functionality has been implemented see sub-tasks of HDFS-12943. > We followed up with the test plan. Testing was done on two independent > clusters (see HDFS-14058 and HDFS-14059) with security enabled. > We ran standard HDFS commands, MR jobs, admin commands including manual > failover. > We know of one cluster running this feature in production. > > Since the previous vote we addressed Daryn's concern (see HDFS-13873), > added documentation for the new feature, and fixed a few other jiras. > > I attached a unified patch to the umbrella jira for the review. > Please vote on this thread. The vote will run for 7 days until Wed Dec 21. > > Thanks, > --Konstantin > -- Zhe Zhang Apache Hadoop Committer https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fzhe-thoughts.github.io%2Fabout%2F&data=02%7C01%7Cekrogen%40linkedin.com%7C641c95c0108143d5648708d662aa1374%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804879950644875&sdata=Pez0NcOVzTI%2BpsvXXvlPzRTJq3SE2efD65zB5krtLak%3D&reserved=0 | @oldcap
