> On Jan 23, 2017, at 8:50 PM, Chris Douglas <chris.doug...@gmail.com> wrote: > > Thanks for all your work on this, Andrew. It's great to see the 3.x > series moving forward. > > If you were willing to modify the release notes and add the LICENSE to > the jar, we don't need to reset the clock on the VOTE, IMO.
FWIW, I wrote a new version of the verify-license-files tool and attached it to HADOOP-13374. This version actually verifies that the license and notice files in jars and wars matches the one in base of the (tarball) distribution. ERROR: hadoop-client-api-3.0.0-alpha3-SNAPSHOT.jar: Missing a LICENSE file ERROR: hadoop-client-api-3.0.0-alpha3-SNAPSHOT.jar: No valid NOTICE found WARNING: hadoop-client-minicluster-3.0.0-alpha3-SNAPSHOT.jar: Found 5 LICENSE files (0 were valid) ERROR: hadoop-client-minicluster-3.0.0-alpha3-SNAPSHOT.jar: No valid LICENSE found WARNING: hadoop-client-minicluster-3.0.0-alpha3-SNAPSHOT.jar: Found 3 NOTICE files (0 were valid) ERROR: hadoop-client-minicluster-3.0.0-alpha3-SNAPSHOT.jar: No valid NOTICE found ERROR: hadoop-client-runtime-3.0.0-alpha3-SNAPSHOT.jar: No valid LICENSE found ERROR: hadoop-client-runtime-3.0.0-alpha3-SNAPSHOT.jar: No valid NOTICE found > What's the issue with the minicluster jar [1]? I tried to reproduce, > but had no issues with 1.8.0_92-b14. minicluster is kind of weird on filesystems that don't support mixed case, like OS X's default HFS+. $ jar tf hadoop-client-minicluster-3.0.0-alpha3-SNAPSHOT.jar | grep -i license LICENSE.txt license/ license/LICENSE license/LICENSE.dom-documentation.txt license/LICENSE.dom-software.txt license/LICENSE.sax.txt license/NOTICE license/README.dom.txt license/README.sax.txt LICENSE Grizzly_THIRDPARTYLICENSEREADME.txt The problem here is that there is a 'license' directory and a file called 'LICENSE'. If this gets extracted by jar via jar xf, it will fail. unzip can be made to extract it via an option like -o. To make matters worse, none of these license files match the one in the generated tarball. :( --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
