Manoj Govindassamy created HDFS-10852:
-----------------------------------------
Summary: Verify existence of all Tool classes mentioned in HDFS
script
Key: HDFS-10852
URL: https://issues.apache.org/jira/browse/HDFS-10852
Project: Hadoop HDFS
Issue Type: Bug
Components: hdfs
Affects Versions: 3.0.0-alpha2
Reporter: Manoj Govindassamy
Assignee: Manoj Govindassamy
Priority: Minor
HDFS script (hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs) delegates user
requests to {{org.apache.hadoop.util.Tool}} implementers based on the classname
mappings in the script. If Tools are refactored like classnames are changed,
then the HDFS script has to be updated to carry the new Tool classname.
Existing unit tests do not go via hdfs script as they construct the Tools
directly and run the operations. So, missing to update HDFS script on any
refactoring might break the CLI. Lets have a test to at least verify the
existence of all Tool classes mentioned in HDFS script.
{noformat}
:grep "HADOOP_CLASSNAME=" ./hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.server.balancer.Balancer
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.CacheAdmin
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.CryptoAdmin
HADOOP_CLASSNAME="org.apache.hadoop.hdfs.server.datanode.SecureDataNodeStarter"
HADOOP_CLASSNAME='org.apache.hadoop.hdfs.server.datanode.DataNode'
HADOOP_CLASSNAME='org.apache.hadoop.hdfs.tools.DebugAdmin'
HADOOP_CLASSNAME=org.apache.hadoop.fs.FsShell
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DFSAdmin
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DiskBalancerCLI
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.erasurecode.ECCli
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DelegationTokenFetcher
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DFSck
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.GetConf
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.GetGroups
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DFSHAAdmin
HADOOP_CLASSNAME='org.apache.hadoop.hdfs.qjournal.server.JournalNode'
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.JMXGet
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.snapshot.LsSnapshottableDir
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.server.mover.Mover
HADOOP_CLASSNAME='org.apache.hadoop.hdfs.server.namenode.NameNode'
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.nfs.nfs3.PrivilegedNfsGatewayStarter
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.nfs.nfs3.Nfs3
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsViewer
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.offlineImageViewer.OfflineImageViewerPB
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.offlineImageViewer.OfflineImageViewer
HADOOP_CLASSNAME=org.apache.hadoop.portmap.Portmap
HADOOP_CLASSNAME='org.apache.hadoop.hdfs.server.namenode.SecondaryNameNode'
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.snapshot.SnapshotDiff
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.StoragePolicyAdmin
HADOOP_CLASSNAME=org.apache.hadoop.util.VersionInfo
HADOOP_CLASSNAME='org.apache.hadoop.hdfs.tools.DFSZKFailoverController'
HADOOP_CLASSNAME="${subcmd}"
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
