Yiqun Lin created HDFS-10813:
--------------------------------

             Summary: DiskBalancer: Add the getNodeList method in Command
                 Key: HDFS-10813
                 URL: https://issues.apache.org/jira/browse/HDFS-10813
             Project: Hadoop HDFS
          Issue Type: Sub-task
          Components: balancer & mover
            Reporter: Yiqun Lin
            Assignee: Yiqun Lin
            Priority: Minor


The method {{Command#getNodeList}} in DiskBalancer was added in HDFS-9545, but 
it's never used. We can improve that in the following aspects:

1.Change {{private}} to {{protected}} so that the subclass can use that method 
in the future.
2.Reuse the method {{Command#getNodeList}} and to construct a new method
like this {{List<DiskBalancerDataNode> getNodes(String listArg)}}. This method 
can be used for getting multiple nodes in the future. For example, if we want 
to use {{hdfs diskbalancer -report -node}} or {{hdfs diskbalancer -plan}} with 
multiple specified nodes, that method can be used.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to