John Zhuge created HDFS-10657:
---------------------------------

             Summary: testAclCLI.xml inherit default ACL to dir test should 
expect mask r-x
                 Key: HDFS-10657
                 URL: https://issues.apache.org/jira/browse/HDFS-10657
             Project: Hadoop HDFS
          Issue Type: Bug
    Affects Versions: 2.6.0
            Reporter: John Zhuge
            Assignee: John Zhuge
            Priority: Minor


The following test case should expect {{mask::r-x}} ACL entry instead of 
{{mask::rwx}}:
{code:xml}
      <description>setfacl : check inherit default ACL to dir</description>
      <test-commands>
        <command>-fs NAMENODE -mkdir /dir1</command>
        <command>-fs NAMENODE -setfacl -m 
default:user:charlie:r-x,default:group:admin:rwx /dir1</command>
        <command>-fs NAMENODE -mkdir /dir1/dir2</command>
        <command>-fs NAMENODE -getfacl /dir1/dir2</command>
...
        <comparator>
          <type>SubstringComparator</type>
          <expected-output>mask::rwx</expected-output>
        </comparator>
{code}

But why does it pass? Because the comparator type is {{SubstringComparator}} 
and it matches the wrong line {{default:mask::rwx}} in the output of 
{{getfacl}}:
{noformat}
# file: /dir1/dir2
# owner: jzhuge
# group: supergroup
user::rwx
user:charlie:r-x
group::r-x
group:admin:rwx #effective:r-x
mask::r-x
other::r-x
default:user::rwx
default:user:charlie:r-x
default:group::r-x
default:group:admin:rwx
default:mask::rwx
default:other::r-x
{noformat}

The comparator should match the entire line instead of just substring. Other 
comparators in {{testAclCLI.xml}} have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to