Lei (Eddy) Xu created HDFS-10600:
------------------------------------
Summary: PlanCommand#getThrsholdPercentage should not use
throughput value.
Key: HDFS-10600
URL: https://issues.apache.org/jira/browse/HDFS-10600
Project: Hadoop HDFS
Issue Type: Sub-task
Components: diskbalancer
Affects Versions: 2.9.0, 3.0.0-beta1
Reporter: Lei (Eddy) Xu
In {{PlanCommand#getThresholdPercentage}}
{code}
private double getThresholdPercentage(CommandLine cmd) {
....
if ((value <= 0.0) || (value > 100.0)) {
value = getConf().getDouble(
DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT,
DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT_DEFAULT);
}
return value;
}
{code}
{{DISK_THROUGHPUT}} has the unit of "MB", so it does not make sense to return
{{throughput}} as a percentage value.
Btw, we should use {{THROUGHPUT}} instead of {{THRUPUT}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
