Hi Todd, This is a great question. I don't see a lot of work from the implementation prospective. I anticipate that the branch-2 patch will be almost identical to the one for trunk.
We plan on merging it into branch-2 after more testings. In my opinion it should fit in the 2.4 timeline. And to clarify, in 2.4 the code will be able to read both the old and the new FSImage format, but it should only write in the new format. That way the developers do not need to write serialization code twice. ~Haohui On Thu, Jan 30, 2014 at 3:18 PM, Todd Lipcon <t...@cloudera.com> wrote: > One question - what's the intention with this work with regard to branch-2? > Do you plan to merge it to branch-2, and if so, are you thinking for 2.4 or > later? > > I'm a little afraid of the divergence between trunk and branch-2 in this > area, since we'll likely want to add new features which require > serialization changes. With the divergent code, we'll need to add them in > trunk in PB form, and in branch-2 in "Writable" form. Sounds like a big > pain for any future backports unless we merge. > > -Todd > > > On Thu, Jan 30, 2014 at 2:37 PM, Haohui Mai <h...@hortonworks.com> wrote: > > > Hello all, > > > > I would like to call a vote to merge of the new protobuf-based FSImage > into > > trunk. > > > > The changes introduce a protobuf-based FSImage format into HDFS. It > > separates the responsibility of serializing and reconstructing the > > namespace in the NameNode using Google's Protocol Buffers > > (protobuf). The new FSImage delegates much parts of the serialization / > > deserialization logics to the protobuf side. It is also designed to > > improve the supports for compatibility and interoperability. > > > > The development has been done in a separate branch: > > https://svn.apache.org/repos/asf/hadoop/common/branches/HDFS-5698 > > > > The design document is available at: > > > > > https://issues.apache.org/jira/secure/attachment/12626179/HDFS-5698-design.pdf > > > > The HDFS-5698 jira tracks the development of the feature. > > > > The feature changes no public APIs. The existing tests include both > > unit tests and end-to-end tests. They have already covered this > > feature. > > > > Once the feature is merged into trunk, we will continue to test and > > fix any bugs that may be found on trunk. > > > > The bulk of the design and implementation was done by Jing Zhao, > > Suresh Srinivas and me. Thanks Kihwal Lee, Todd Lipcon, Colin > > Patrick McCabe, Chris Nauroth, and Daryn Sharp for providing feedback on > > the jiras and in discussions. > > > > This vote runs for a week and closes on 2/6/2013 at 11:59 pm PT. > > > > Regards, > > Haohui > > > > -- > > CONFIDENTIALITY NOTICE > > NOTICE: This message is intended for the use of the individual or entity > to > > which it is addressed and may contain information that is confidential, > > privileged and exempt from disclosure under applicable law. If the reader > > of this message is not the intended recipient, you are hereby notified > that > > any printing, copying, dissemination, distribution, disclosure or > > forwarding of this communication is strictly prohibited. If you have > > received this communication in error, please contact the sender > immediately > > and delete it from your system. Thank You. > > > > > > -- > Todd Lipcon > Software Engineer, Cloudera > -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
