Jing Zhao created HDFS-5633: ------------------------------- Summary: Improve OfflineImageViewer to use less memory Key: HDFS-5633 URL: https://issues.apache.org/jira/browse/HDFS-5633 Project: Hadoop HDFS Issue Type: Improvement Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor
Currently after we rename a file/dir which is included in a snapshot, the file/dir can be linked with two different reference INodes. To avoid saving/loading the inode multiple times in/from FSImage, we use a temporary map to record whether we have visited this inode before. However, in OfflineImageViewer (specifically, in ImageLoaderCurrent), the current implementation simply records all the directory inodes. This can take a lot of memory when the fsimage is big. We should only record an inode in the temp map when it is referenced by an INodeReference, just like what we do in FSImageFormat. -- This message was sent by Atlassian JIRA (v6.1#6144)