[jira] [Created] (HDFS-5582) hdfs getconf -excludeFile or -includeFile always failed

[Henry Hung (JIRA)]

Henry Hung created HDFS-5582:
--------------------------------

             Summary: hdfs getconf -excludeFile or -includeFile always failed
                 Key: HDFS-5582
                 URL: https://issues.apache.org/jira/browse/HDFS-5582
             Project: Hadoop HDFS
          Issue Type: Bug
    Affects Versions: 2.2.0
            Reporter: Henry Hung
            Priority: Minor


In hadoop-2.2.0, if you execute getconf for exclude and include file, it will 
return this error message:

{code}
[hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -excludeFile
Configuration DFSConfigKeys.DFS_HOSTS_EXCLUDE is missing.

[hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -includeFile
Configuration DFSConfigKeys.DFS_HOSTS is missing.
{code}

I found out the root cause is very simple, it’s because the source code of 
{{org/apache/hadoop/hdfs/tools/GetConf.java}} hard coded it to 
{{"DFSConfigKeys.DFS_HOSTS"}} and {{"DFSConfigKeys.DFS_HOSTS_EXCLUDE"}}

{code}
      map.put(INCLUDE_FILE.getName().toLowerCase(), 
          new CommandHandler("DFSConfigKeys.DFS_HOSTS"));
      map.put(EXCLUDE_FILE.getName().toLowerCase(),
          new CommandHandler("DFSConfigKeys.DFS_HOSTS_EXCLUDE"));
{code}

A simple fix would be to remove the quote:

{code}
      map.put(INCLUDE_FILE.getName().toLowerCase(), 
          new CommandHandler(DFSConfigKeys.DFS_HOSTS));
      map.put(EXCLUDE_FILE.getName().toLowerCase(),
          new CommandHandler(DFSConfigKeys.DFS_HOSTS_EXCLUDE));
{code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)