[ https://issues.apache.org/jira/browse/HDFS-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HDFS-4707. ------------------------------------------ Resolution: Fixed Fix Version/s: Snapshot (HDFS-2802) Hadoop Flags: Reviewed Thanks Jing for reviewing the patch. I have committed this. > Fix FilterFileSystem and findbugs warning in Snapshot branch > ------------------------------------------------------------ > > Key: HDFS-4707 > URL: https://issues.apache.org/jira/browse/HDFS-4707 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Fix For: Snapshot (HDFS-2802) > > Attachments: h4707_20130417.patch > > > The snapshot methods are not added to FilterFileSystem. > Findbugs warnings: > - SIC Should snapshot.Snapshot$Root be a _static_ inner class? > - WMI Method FSImageFormat$Saver.saveImage(ByteBuffer, > INodeDirectory, DataOutputStream, Snapshot, boolean) makes inefficient use of > keySet iterator instead of entrySet iterator > - BC Unchecked/unconfirmed cast from > FSImageSerialization.writeINodeFile(INodeFile, DataOutput, boolean) > - BC Unchecked/unconfirmed cast from > snapshot.SnapshotFSImageFormat.loadDirectoryDiffList(INodeDirectory, > DataInput, FSImageFormat$Loader) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira