On Thu, Feb 21, 2013 at 1:24 PM, Chris Douglas <cdoug...@apache.org> wrote: > On Wed, Feb 20, 2013 at 5:12 PM, Aaron T. Myers <a...@cloudera.com> wrote: >> Given that the only substantive concerns with HDFS-347 seem to be about >> Windows support for local reads, for now we only merge this branch to >> trunk. Support for doing HDFS-2246 style local reads will be removed from >> trunk, but retained in branch-2 for now. Only once someone adds support for >> doing HDFS-347 style local reads which work on Windows will we consider >> merging HDFS-347 to branch-2. This should ensure that there's no feature >> regression on branch-2, but also means that we will not need to maintain >> the HDFS-2246 code path alongside the HDFS-347 code path indefinitely. > > This seems reasonable, though retaining HDFS-2246 in branch-2 could be > a workaround if a Windows port of HDFS-347 is not forthcoming. -C
This seems like a reasonable solution to me. To implement this on Windows, you would use the DuplicateHandle or WSADuplicateSocket APIs on that platform. I think the longer we delay the merge, the less time we will actually have to implement secure short-circuit on Windows. So we should not delay it any longer. best, Colin
