[ https://issues.apache.org/jira/browse/HDFS-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HDFS-4245. ------------------------------------------ Resolution: Fixed Fix Version/s: Snapshot (HDFS-2802) I have committed this. Thanks, Jing! > Include snapshot related operations in > OfflineEditsViewerHelper#runOperations() to fix test failures in > TestOfflineEditsViewer > ------------------------------------------------------------------------------------------------------------------------------ > > Key: HDFS-4245 > URL: https://issues.apache.org/jira/browse/HDFS-4245 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Reporter: Jing Zhao > Assignee: Jing Zhao > Priority: Minor > Fix For: Snapshot (HDFS-2802) > > Attachments: editsStored, editsStored, HDFS-4245.001.patch, > HDFS-4245.002.patch > > > We have the following test failure for snapshot: > {noformat} > java.lang.AssertionError: Edits > /home/jenkins/jenkins-slave/workspace/Hadoop-Hdfs-Snapshots-Branch-build/trunk/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/name/current/edits_0000000000000000001-0000000000000000059 > should have all op codes > at org.junit.Assert.fail(Assert.java:91) > at org.junit.Assert.assertTrue(Assert.java:43) > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.__CLR3_0_2lvw0fw1wtx(TestOfflineEditsViewer.java:103) > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.testGenerated(TestOfflineEditsViewer.java:86) > ... > {noformat} > {noformat} > java.lang.AssertionError: Edits > /home/jenkins/jenkins-slave/workspace/Hadoop-Hdfs-Snapshots-Branch-build/trunk/hadoop-hdfs-project/hadoop-hdfs/target/test-classes/editsStored > should have all op codes > at org.junit.Assert.fail(Assert.java:91) > at org.junit.Assert.assertTrue(Assert.java:43) > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.__CLR3_0_2yzsf441wup(TestOfflineEditsViewer.java:171) > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.testStored(TestOfflineEditsViewer.java:153) > ... > {noformat} > We need to update OfflineEditsViewerHelper#runOperations() and editsStored to > include snapshot related operations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira