Binglin Chang created HDFS-4165: ----------------------------------- Summary: Faulty sanity check in FsDirectory.unprotectedSetQuota Key: HDFS-4165 URL: https://issues.apache.org/jira/browse/HDFS-4165 Project: Hadoop HDFS Issue Type: Bug Reporter: Binglin Chang Priority: Trivial
According to the documentation: The quota can have three types of values : (1) 0 or more will set the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET} implies the quota will be reset. Any other value is a runtime error. sanity check in FsDirectory.unprotectedSetQuota should use {code} nsQuota != HdfsConstants.QUOTA_RESET {code} rather than {code} nsQuota < HdfsConstants.QUOTA_RESET {code} Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem for this code, but it is better to do it right. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira