[ https://issues.apache.org/jira/browse/HDFS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HDFS-3652. ------------------------------- Resolution: Fixed Fix Version/s: 1.2.0 1.1.0 1.0.4 Hadoop Flags: Reviewed Committed to branch-1, branch-1.0, and branch-1.1. > 1.x: FSEditLog failure removes the wrong edit stream when storage dirs have > same name > ------------------------------------------------------------------------------------- > > Key: HDFS-3652 > URL: https://issues.apache.org/jira/browse/HDFS-3652 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 1.0.3, 1.1.0, 1.2.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Blocker > Fix For: 1.0.4, 1.1.0, 1.2.0 > > Attachments: hdfs-3652.txt > > > In {{FSEditLog.removeEditsForStorageDir}}, we iterate over the edits streams > trying to find the stream corresponding to a given dir. To check equality, we > currently use the following condition: > {code} > File parentDir = getStorageDirForStream(idx); > if (parentDir.getName().equals(sd.getRoot().getName())) { > {code} > ... which is horribly incorrect. If two or more storage dirs happen to have > the same terminal path component (eg /data/1/nn and /data/2/nn) then it will > pick the wrong stream(s) to remove. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira