Matthew Jacobs created HDFS-3446: ------------------------------------ Summary: HostsFileReader silently ignores bad includes/excludes Key: HDFS-3446 URL: https://issues.apache.org/jira/browse/HDFS-3446 Project: Hadoop HDFS Issue Type: Bug Components: name-node Affects Versions: 1.0.0, 2.0.0 Reporter: Matthew Jacobs Assignee: Matthew Jacobs
The HostsFileReader silently fails if the includes or excludes files do not exist or are not readable. The current behavior is to overwrite the existing set of hosts or excluded hosts, regardless of whether or not the includes/excludes file exists. This behavior was introduced in HADOOP-5643 to support updating the job tracker's node lists. The HostsFileReader is no longer used by the job tracker. If this behavior was intentional, it no longer seems necessary for any reason. The HostsFileReader is still used by NodeListManager as well as the DatanodeManager, and in both cases, throwing an exception when the include/exclude files aren't found/readable is desirable. We should validate the given includes and excludes files before using them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira