Refactor BPOfferService to be a static inner class
--------------------------------------------------
Key: HDFS-2560
URL: https://issues.apache.org/jira/browse/HDFS-2560
Project: Hadoop HDFS
Issue Type: Improvement
Components: data-node
Affects Versions: 0.23.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Currently BPOfferService is a non-static inner class of DataNode. For HA we are
adding another inner class inside of this, which makes the scope very hard to
understand when reading the code (and has resulted in subtle bugs like
HDFS-2529 where a variable is referenced from the wrong scope. Making it a
static inner class with a reference to the DN has two advantages: a) scope is
now explicit, and b) enables unit testing of the BPOS against a mocked-out DN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
