Checkpointer should trigger checkpoint with specified period.
-------------------------------------------------------------
Key: HDFS-1572
URL: https://issues.apache.org/jira/browse/HDFS-1572
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Liyin Liang
Priority: Blocker
{code:}
long now = now();
boolean shouldCheckpoint = false;
if(now >= lastCheckpointTime + periodMSec) {
shouldCheckpoint = true;
} else {
long size = getJournalSize();
if(size >= checkpointSize)
shouldCheckpoint = true;
}
{code}
{dfs.namenode.checkpoint.period} in configuration determines the period of
checkpoint. However, with above code, the Checkpointer triggers a checkpoint
every 5 minutes (periodMSec=5*60*1000). According to SecondaryNameNode.java,
the first *if* statement should be:
{code:}
if(now >= lastCheckpointTime + 1000 * checkpointPeriod) {
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
