blocksWritten metric is double-incremented for blocks received via replication
------------------------------------------------------------------------------

                 Key: HDFS-828
                 URL: https://issues.apache.org/jira/browse/HDFS-828
             Project: Hadoop HDFS
          Issue Type: Bug
    Affects Versions: 0.22.0
            Reporter: Todd Lipcon


DataNode.closeBlock() takes care of incrementing the blocksWritten counter. 
However, BlockReceiver does this too when receiving from another DN. To test, I 
added log messages in both spots and ran TestReplication:

2009-12-14 17:38:10,656 WARN  datanode.DataNode 
(BlockReceiver.java:receiveBlock(614)) - Incrementing counter in receiveBlock 
for block: blk_7127492210831810737_1001 in DN 
DataNode{data=FSDataset{dirpath='/home/todd/git/hadoop-hdfs/build/test/data/dfs/data/data15/current/finalized,/home/todd/git/hadoop-hdfs/build/test/data/dfs/data/data16/current/finalized'},
 localName='127.0.0.1:54069', 
storageID='DS-896316964-127.0.1.1-54069-1260841088335', xmitsInProgress=0}
2009-12-14 17:38:10,656 WARN  datanode.DataNode 
(DataNode.java:closeBlock(1289)) -  Incrementing counter in closeBlock for 
block: blk_7127492210831810737_1001 in DN 
DataNode{data=FSDataset{dirpath='/home/todd/git/hadoop-hdfs/build/test/data/dfs/data/data15/current/finalized,/home/todd/git/hadoop-hdfs/build/test/data/dfs/data/data16/current/finalized'},
 localName='127.0.0.1:54069', 
storageID='DS-896316964-127.0.1.1-54069-1260841088335', xmitsInProgress=0}

(note that the block ID and DN are the same in both)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to