On 04/12/2017 18:52, Allen Byrne wrote:
Thank you for your contribution, we are always looking for ways to improve the CMake code. I have just recently updated the target_link_libraries calls to use the interface keywords and have now added this suggestion to that change.
Unfortunately, my testing is showing that hdf5 is still broken due to the command line length limits being too short (https://ci.openmicroscopy.org/view/Files/job/OME-FILES-CPP-DEV-merge-win-superbuild/VSARCH=x64,VSCONFIG=Release,VSVERSION=14,label=maxquant-ome/823/consoleText): [1500/2985] Generating th5s.h5 FAILED: cmd.exe /C "cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-help1.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-help1.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-cmpd1.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-cmpd1.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-cmpd2.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-cmpd2.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-cmpd3.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-cmpd3.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-cmpd4.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-cmpd4.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-cmpd5.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-cmpd5.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-dset1.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-dset1.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-dset2.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-dset2.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-dset-nomax.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-dset-nomax.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-dset-none.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-dset-none.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-file.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-file.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-poll.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-poll.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-poll0.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-poll0.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-err-width.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-err-width.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-esc.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-esc.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-esc-f1.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-esc-f1.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-esc-f3.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-esc-f3.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-esc-ff2.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-esc-ff2.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-f1.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-f1.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-f2.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-f2.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-ff3.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-ff3.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-label.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-label.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-two.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-two.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-two-f1.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-two-f1.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-two-f3.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-two-f3.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-cmpd-two-ff2.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-cmpd-two-ff2.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-early.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-early.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-late.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-late.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-one.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-one.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-one-d.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-one-d.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-one-simple.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-one-simple.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-two.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-two.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-two-d.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-two-d.ddl && cd /D D:\build\OME-FILES-CPP-DEV-merge-win-superbuild\af9fc46c\build\hdf5-build\hl\tools\h5watch && "C:\Program Files\CMake\bin\cmake.exe" -E copy_if_different D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-source/hl/tools/testfiles/w-ext-two-width.ddl D:/build/OME-FILES-CPP-DEV-merge-win-superbuild/af9fc46c/build/hdf5-build/hl/tools/h5watch/testfiles/w-ext-two-width.ddl" I reported this to you, with a demonstration of how fix it, last year (8th August 2016, "Compile and test failures with hdf5-1.10.0-patch1"). This is on Windows, VS2015 x64, with the Ninja generator. I can make a full patch for this, but it would need to be against the current state of your codebase. Is that available anywhere? Regards, Roger The University of Dundee is a registered Scottish Charity, No: SC015096 _______________________________________________ Hdf-forum is for HDF software users discussion. Hdf-forum@lists.hdfgroup.org http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org Twitter: https://twitter.com/hdf5
