Can you fix your mailer so that it quotes properly? Down below, you
wrote "Good idea. :)" and Mark wrote "I'm going to submit...." and they
have the same level of quoting... we can't follow the thread...
thanks
geir
LvJimmy，Jing wrote:
2006/4/17, Mark Hindess <[EMAIL PROTECTED]>:
Another type of test that could be improved are those using
assertTrue to compare two objects for equality. Most of them should
be using assertEquals, assertNull or assertNotNull.
Using assertEquals automatically gives more meaningful error messages.
It saves people writing asserts like:
assertTrue("Size should return 100, returned: " + map.size(),
map.size() == 100);
when this would do just as well:
assertEquals("Incorrect size", 100, map.size());
Good idea. :)
I'm going to submit a few (big) patches to fix some of these.
I think there's a lot of them, even, few of our testcases is written in this
style, so, good luck :)
Anyway, we can discuss about this, and see if we can agree on some
convention.
Regards,
Mark.
On 4/15/06, Mark Hindess <[EMAIL PROTECTED]> wrote:
Trying to fix/enable the PatternSyntaxExceptionTest (HARMONY-352) was
quite confusing. If you get the arguments to assertEquals the wrong
way around you get errors like:
error expected <actual> but got <expected>
rather than:
error expected <expected> but got <actual>
The correct way around is to have the expected value before the actual
value.
We should all try make sure we get the arguments to assertEquals in the
correct order. And fix any we spot that are the wrong way around. ;-)
I've fixed a few of the more obviously incorrect method calls in
HARMONY-353.
Regards,
Mark.
--
Mark Hindess <[EMAIL PROTECTED]>
IBM Java Technology Centre, UK.
--
Mark Hindess <[EMAIL PROTECTED]>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Best Regards!
Jimmy, Jing Lv
China Software Development Lab, IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
