Ok. I agree actually. I assumed because the contribution did it this way, and had been accepted, that it had been agreed that it was ok. I will make a clear distinction between the "check" and "fetch" targets. Only "check" will be used unless the fetch is invoked explicity.
Regards, Mark. On 3/16/06, Tim Ellison <[EMAIL PROTECTED]> wrote: > Thanks Mark -- I really object to regular builds reaching out over the > web. For now I may just make it a separate target or a simple ant > existence check. > > Regards, > Tim > > Mark Hindess wrote: > > Mikhail, > > > > I took a few shortcuts getting these integration done. I'm planning > > to factor out the acquire depends jars step in to a separate ant file. > > My current plan is to create a new make/depends.xml file that would > > be responsible for fetching the files and have the make/build.xml use > > that to check for the presence of the files and only run the get tasks > > file if any files are missing. (Ditto for make/build-test.xml which > > currently duplicates this download process.) > > > > This way, if you have the required jars in the correct location then > > it should be possible to avoid the HTTP If-Modified queries that are > > causing your problems. > > > > Once I've fixed these problems that I created then I intend to look at > > HARMONY-196 to see if that contribution can be added to the > > make/depends.xml step. > > > > Regards, > > Mark. > > > > On 3/16/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote: > >> Tim, Mark > >> > >> revisions 386087, 386171 of that file break my build: > >> > >> prepare-depends: > >> [get] Getting: > >> http://www.ibiblio.org/maven/xalan/jars/xalan-2.6.0.jar > >> [get] To: C:\harmony\depends\jars\xalan-j_2.6.0\xalan.jar > >> [get] Error getting > >> http://www.ibiblio.org/maven/xalan/jars/xalan-2.6.0.jar to C:\ > >> depends\jars\xalan-j_2.6.0\xalan.jar > >> > >> BUILD FAILED > >> C:\harmony\make\build.xml:36: The following error occurred while > >> executing this line: > >> C:\harmony\make\build-java.xml:352: java.net.NoRouteToHostException: > >> Operation timed out > >> > >> The problem seems to be with proxy setting > >> > >> Thanks, > >> Mikhail Loenko > >> Intel Middleware Products Division > >> > >> > >> 2006/3/16, Mark Hindess <[EMAIL PROTECTED]>: > >>> Thanks Tim. I spotted that I'd missed that one too. > >>> > >>> -Mark. > >>> > >>> On 3/15/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > >>>> Author: tellison > >>>> Date: Wed Mar 15 13:37:44 2006 > >>>> New Revision: 386171 > >>>> > >>>> URL: http://svn.apache.org/viewcvs?rev=386171&view=rev > >>>> Log: > >>>> Ensure the XML JARs go directly into the boot dir > >>>> > >>>> Modified: > >>>> incubator/harmony/enhanced/classlib/trunk/make/build-java.xml > >>>> > >>>> Modified: incubator/harmony/enhanced/classlib/trunk/make/build-java.xml > >>>> URL: > >>>> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/make/build-java.xml?rev=386171&r1=386170&r2=386171&view=diff > >>>> ============================================================================== > >>>> --- incubator/harmony/enhanced/classlib/trunk/make/build-java.xml > >>>> (original) > >>>> +++ incubator/harmony/enhanced/classlib/trunk/make/build-java.xml Wed > >>>> Mar 15 13:37:44 2006 > >>>> @@ -282,7 +282,7 @@ > >>>> > >>>> <!-- Copy across the dependency jars --> > >>>> <copy todir="${target.output}/jre/lib/boot" overwrite="yes" > >>>> - verbose="yes"> > >>>> + verbose="yes" flatten="yes"> > >>>> <fileset dir="${depends.jars}"> > >>>> <patternset includes="*.jar" /> > >>>> <patternset includes="xerces_2.6.2/*.jar" /> > >>>> > >>>> > >>>> > >>> > >>> -- > >>> Mark Hindess <[EMAIL PROTECTED]> > >>> IBM Java Technology Centre, UK. > >>> > > > > > > -- > > Mark Hindess <[EMAIL PROTECTED]> > > IBM Java Technology Centre, UK. > > > > -- > > Tim Ellison ([EMAIL PROTECTED]) > IBM Java technology centre, UK. > -- Mark Hindess <[EMAIL PROTECTED]> IBM Java Technology Centre, UK.
