Thanks very much, I'll update the code. I have two questions/notes:
- I noticed that COM_NUM may not be what original CT does, though the NG is a little bit easy to misunderstand. It looks COM_NUM() now returns next free slot, while in CT it returned maximum number of com ports. - If COM_NUM() returns max number of port slots, how to retrieve next free one? Viktor On 2010 May 27, at 09:05, Przemysław Czerpak wrote: > On Wed, 26 May 2010, vszak...@users.sourceforge.net wrote: > > Hi, > >> 2010-05-27 00:15 UTC+0200 Viktor Szakats (harbour.01 syenar.hu) >> * utils/hbmk2/examples/contribf.hbc >> * contrib/Makefile >> + contrib/hbcomm >> + contrib/hbcomm/Makefile >> + contrib/hbcomm/hbcomm.hbc >> + contrib/hbcomm/hbcomm.prg >> + contrib/hbcomm/hbcomm.hbp >> + contrib/hbcomm/tests >> + contrib/hbcomm/tests/hbmk.hbm >> + contrib/hbcomm/tests/test.prg >> + Added HBCOMM compatibility library. It's based on hbct >> COM functions. Not tested with real port. Also see one >> TOFIX and one INCOMPATIBILITY note inside. The latter >> belongs to INCHR() function which in original HBCOMM >> library will do HVM corruption by overwriting string >> content passed as 3rd parameter. In Harbour 3rd >> parameter needs to be passed by reference. >> Also added fully adapted test code from HARBOUR MINIGUI >> project. Interestingly this code was using the return >> value of INCHR() to get the returned buffer, which was >> in sync with included HBCOMM code. Anyway, hopefully >> this can be finalized based on report from real users. > > Thank you for your contribution. > I do not know HBCOMM library so I cannot help you much but you > wrote in the code: > > /* Send out characters. Returns .t. if successful. */ > FUNCTION OUTCHR( nPort, cString ) > RETURN com_send( nPort, cString ) > > and this function return number of character which were not sent. > If your comment is correct then it should be changed to: > > FUNCTION OUTCHR( nPort, cString ) > RETURN com_send( nPort, cString ) == 0 > > otherwise the description should be updated. > > best regards, > Przemek > _______________________________________________ > Harbour mailing list (attachment size limit: 40KB) > Harbour@harbour-project.org > http://lists.harbour-project.org/mailman/listinfo/harbour _______________________________________________ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
