Hi,

>  + contrib/hbqt/hbqt.h
>    + Added: constants hbqt_par_Qsci* 
>      ; TODO make them local.

This is serious modularization fault, 
even for an initial upload. Pls fix it.

>    + Initial upload of wrappers for QScintilla.
>      To generate the sources auto you need to stay in hbqt/hbqscintilla
>      and issue ../generator/hbqtgen.
> 
>      HB_WITH_QSCINTILLA and HB_WITH_QT need be properly defined.
>      I am still finding where to host modified QScintilla, any tips ?

Are you sure you need to modify this 
external lib to make it work with HBQT?

My suggestion is to keep modifications to 
barest minimum, subclass instead, include 
Harbour specific stuff (like lexer) inside 
the wrapper lib, and submit any fixes to 
author, until he applies them (IF he applies 
them) workaround your wrapper code to work 
with plain vanilla unfixed QSCINTILLA code.

This way everyone can get the QSCINTILLA 
component from its original, official source, 
just like they do for all other 3rd party 
components. This method scales much better 
than if you start maintaining a 3rd party 
library source and users have no other choice 
than relying on you (and only you) to get 
those sources in usable form. They also rely 
on you to get updates. This is essentially 
a QSCINTILLA _fork_ as of current state.

Viktor

_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to