>> I hope someone can fix these. These were so far >> hidden because of turned off warnings for exotic >> compilers like bcc/pocc/xcc when building >> external libs. Now they are visible. > > This bug exists with _ALL_ C compilers we are using. > Just simply your recent modifications enabled warnings only > for few compilers but many others like all GCC based ones > still does not report any warnings so such bugs are invisible.
I reached the point where I can't do more with the issue. If a warning is not reported in default warning mode I have to assume it's not grave, or the compiler is just plain careless, but anyhow it's not something I'm willing to tweak forever. > Missing prototypes means that C compiler may incorrectly create > function call frame so final code will GPF or fail in other way > depending on used ABI and type of parameters. > >> If the problems won't be resolved, I will simply >> disable failing libs for these targets. > > To fix such problems it's necessary to know about them > and this library is yet another example that disabled > warnings may cause that we are creating wrong binaries > without any knowledge about it. There is no _disabled_ warnings in Harbour now. There are two modes: 1) default warning level 2) Harbour high level warnings. If someone wishes to deal with the issue, one can up the default warning level explicitly to some higher one, but in this case we can easily come back to the initial issue with lots of required local patches to external code, which in turn nobody likes to create in the first place (besides you), nobody manages throughout updates (besides you and me), nobody submits upstream (besides me), and which I need maintain .dif files for (BTW I'm stopping doing that from today). > The problem is that nearly all of these libraries uses > autoconf to generate configuration header files but we > not and we are using in all builds only some statically > defined for chosen platform files without real system > dependent configuration so such definition can be wrong > and broken code is generated. With fully disabled warnings > we do not know about it. Harbour doesn't explicitly select "fully disabled warnings". (if it still does because I missed some, pls report it) To repeat, if someone would like to deal with it, it's enough to start upping the "default" level explicitly to have a good balance between catching real problems and leaving uninteresting warnings turned off. It's not solution however to use our highest level, because it generates so much warnings, that we won't readily notice the important ones among them, and it would be just unmaintainable to have huge local patches to reach our own level of code quality. > In this particular case (JPEG library) HAVE_PROTOTYPES > definition is missing and it's the reason of above errors > in _all_ builds (we do not support any old C compiler which > does not support prototypes). Thank you. Brgds, Viktor _______________________________________________ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
