Hi, >> Thank you very much. >> Harbour standard warning level was not enabled >> to avoid watching the large amount of warnings >> 3rd party sources are usually causing. >> >> I know they can be fixed with local patches, but >> IMO minimizing number of local patches is a higher >> level goal than the current problem when lack of >> strict warning causes problems after an update. > > Not in this case. These warnings were caused by very serious bugs. > If I wouldn't tested it then probably we released wrong binaries. > Working code is much more important then pacifying warnings. > I can leave with warnings but broken binaries are useless > for me. > >> Now I'm getting attached warnings with msvc, bcc >> and pocc. (mingw is clean) > > BCC and POCC does not fully recognize old style function > declarations so in this case they can be generat wrong > code. > Looks that MSVC warnings can be ignored. > >> Maybe msvc ones can be suppressed with a #pragma? > > and setting _CRT_SECURE_NO_WARNINGS. > Seem that all can be done in zutil.h and gzguts.h.
Can you do it? It's not very good to have 40KB of warning in normal builds. > BTW this version does not set -DZLIB_DLL when compiled as > dynamic code. Can you be more specific? I've been looking for ZLIB_DLL trick in our own build code, but couldn't find any so to me it looks the same as before. Can be I missed something. zlib has the same code: ...\hb-r200\external\zlib>grep ZLIB_DLL * zconf.h:213: /* If building or using zlib as a DLL, define ZLIB_DLL. zconf.h:216:# ifdef ZLIB_DLL zconf.h:224:# endif /* ZLIB_DLL */ zconf.h:246:# ifdef ZLIB_DLL ...\harbour\harbour\external\zlib>grep ZLIB_DLL * zconf.h:285: /* If building or using zlib as a DLL, define ZLIB_DLL. zconf.h:288:# ifdef ZLIB_DLL zconf.h:296:# endif /* ZLIB_DLL */ zconf.h:318:# ifdef ZLIB_DLL Brgds, Viktor _______________________________________________ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
