Hi Xavi, >> ! Fixed new warning in hb_tstrncat() (assigment in conditional). >> I've now basically restored my original version taken from common lib. > > Only one small observation as a comment. > > Not is the same UNICODE NULL L'\0' that '\0', may be irrelevant because both > are zero. > Not is the same while( *pStr ) that while( *pStr != '\0' ). > > IMHO maybe we need to define HB_TEXT and HB_T as TCHAR's _TEXT, _T macros. > It's common practice in windows use _TEXT for user messages and _T for > internals like _T('\0'), I may be wrong and we just need to one macro but not > only for WinCE.
That's true, but I couldn't find a rule here. We're using plain '\0' in several places where we assign chars in UNICODE mode simply as 'x'. So, in comparisons, should we always use _T(), while in assigments, this is not required? Brgds, Viktor _______________________________________________ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour