Just realized that also hb_[v]snprintf() is calling hb_xgrab()
internally, but I can't say if it's actually called when processing
mask present in hbtrace code.

Maybe it's better to restore disabler-hack? (in this case though
probably a less global solution is enough around hb_[v]snprintf()
calls.

Pls advise. (also check va_end() issue)

Brgds,
Viktor

On Mon, Dec 28, 2009 at 2:04 AM, <vszak...@users.sourceforge.net> wrote:

> Revision: 13402
>
> http://harbour-project.svn.sourceforge.net/harbour-project/?rev=13402&view=rev
> Author:   vszakats
> Date:     2009-12-28 01:04:24 +0000 (Mon, 28 Dec 2009)
>
> Log Message:
> -----------
> 2009-12-28 01:56 UTC+0100 Viktor Szakats (harbour.01 syenar.hu)
>  * src/common/hbtrace.c
>    ! Fixed to not call hb_xgrab() via HB_TRACE_CONVTO() causing
>      infinite recursion into trace engine. This replaces previously
>      committed trick to avoid the same thing in a generic manner.
>      It was a bug in previous Windows-support addition, which is now fixed.
>    * Adding \r\n for OutputDebugString() text to make WinDbg display
>      look readable, this time by simply extending printf() mask.
>    - Deleted space trimming from OutputDebugString() passed text.
>      Such issues should be fixed in high level code, it's not trace
>      engine's job to make cosmetic corrections on trace text content.
>    ; Tested with both WinDbg and DbgView.
>      [TOMERGE 2.0]
>
>    ; TOFIX:
>         va_end() has been commented for all platforms, although
>         it's required by all documentation I could verify.
>         If this causes problems for specific platforms/compilers,
>         we should only add this hack for those targets, and only
>         when HB_TR_WINOUT is enabled.
>         Now every non-Windows and Windows non-HB_TR_WINOUT
>         setups are not complying with CRTL documentation.
>         Could someone help here?
>
> Modified Paths:
> --------------
>    trunk/harbour/ChangeLog
>    trunk/harbour/src/common/hbtrace.c
>
>
> This was sent by the SourceForge.net collaborative development platform,
> the world's largest Open Source development site.
> _______________________________________________
> Harbour mailing list (attachment size limit: 40KB)
> Harbour@harbour-project.org
> http://lists.harbour-project.org/mailman/listinfo/harbour
>
_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to