Hello Viktor
Viktor Szakáts wrote:
>
> I'd like to ask/suggest two things:
>
> 1) QT_PTROF() is still used in these places:
>
> xbpbrowse.prg:517: ::connect( QT_PTROF( ::oLeftView ) ,
> "mousePressEvent()" , {|o,p| ::exeBlock( 31, p, o ) } )
> xbpbrowse.prg:518: ::connect( QT_PTROF( ::oLeftHeaderView ),
> "sectionPressed(int)", {|o,i| ::exeBlock( 31, i, o ) } )
> xbpbrowse.prg:519: ::connect( QT_PTROF( ::oLeftFooterView ),
> "sectionPressed(int)", {|o,i| ::exeBlock( 31, i, o ) } )
> xbpbrowse.prg:563: ::connect( QT_PTROF( ::oRightView ) ,
> "mousePressEvent()" , {|o,p| ::exeBlock( 31, p, o ) } )
> xbpbrowse.prg:564: ::connect( QT_PTROF( ::oRightHeaderView ),
> "sectionPressed(int)", {|o,i| ::exeBlock( 31, i, o ) } )
> xbpbrowse.prg:565: ::connect( QT_PTROF( ::oRightFooterView ),
> "sectionPressed(int)", {|o,i| ::exeBlock( 31, i, o ) } )
> xbpbrowse.prg:592: ::connect( QT_PTROF( ::oTableView ),
> "keyPressEvent()" , {|o,p | ::exeBlock( 1, p, o ) } )
> xbpbrowse.prg:593: ::connect( QT_PTROF( ::oTableView ),
> "mousePressEvent()" , {|o,p | ::exeBlock( 2, p, o ) } )
> xbpbrowse.prg:594: ::connect( QT_PTROF( ::oTableView ),
> "mouseDoubleClickEvent()" , {|o,p | ::exeBlock( 3, p, o ) } )
> xbpbrowse.prg:595: ::connect( QT_PTROF( ::oTableView ), "wheelEvent()"
>
> , {|o,p | ::exeBlock( 4, p, o ) } )
> xbpbrowse.prg:596: ::connect( QT_PTROF( ::oTableView ),
> "scrollContentsBy(int,int)" , {|o,p,p1| ::exeBlock(11, p, p1, o ) } )
> xbpbrowse.prg:603: ::connect( QT_PTROF( ::oHScrollBar ),
> "actionTriggered(int)" , {|o,i| ::exeBlock( 103, i, o ) } )
> xbpbrowse.prg:604: ::connect( QT_PTROF( ::oHScrollBar ),
> "sliderReleased()" , {|o,i| ::exeBlock( 104, i, o ) } )
> xbpbrowse.prg:611: ::connect( QT_PTROF( ::oVScrollBar ),
> "actionTriggered(int)" , {|o,i| ::exeBlock( 101, i, o ) } )
> xbpbrowse.prg:612: ::connect( QT_PTROF( ::oVScrollBar ),
> "sliderReleased()" , {|o,i| ::exeBlock( 102, i, o ) } )
> xbpbrowse.prg:624: ::connect( QT_PTROF( ::oHeaderView ),
> "sectionPressed(int)" , {|o,i | ::exeBlock( 111, i, o ) } )
> xbpbrowse.prg:625: ::connect( QT_PTROF( ::oHeaderView ),
> "sectionResized(int,int,int)", {|o,i,i1,i2| ::exeBlock( 121, i, i1, i2, o
> ) } )
> xbprtf.prg:487: oBrush := QBrush():new( "QColor", QT_PTROF( oColor
> ) )
> xbpwindow.prg:262: ACCESS pWidget INLINE
> IF( empty( ::oWidget ), NIL, QT_PTROF( ::oWidget ) )
> xbpwindow.prg:263: ACCESS pParent INLINE
> IF( empty( ::oParent ), NIL, QT_PTROF( ::oParent:oWidget ) )
>
> Are these all required?
>
> 2) QT_PTROFXBP() now has a double purpose, so it would
> seem cleaner to change such code:
>
> ::oWidget:addWidget( QT_PTROFXBP( oPanel ) )
>
> to either:
>
> ::oWidget:addWidget( oPanel:oWidget )
>
> or, if :pPtr is really required, to:
>
> ::oWidget:addWidget( QT_PTROF( oPanel:oWidget ) )
>
> After this it would be possible to simply drop QT_PTROFXBP(),
> and use QT_PTROF(), which would seem much cleaner.
>
Let me review the whole concept.
Will come back shortly.
Regards
Pritpal Bedi
--
View this message in context:
http://old.nabble.com/QT_PTROF%28%29---QT_PTROFXBP%28%29-tp26854048p26856490.html
Sent from the Harbour - Dev mailing list archive at Nabble.com.
_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour
