Hi Viktor
I see you made this change to win_prt.c in WIN_PORTREAD:
lpBuffer = ( char * ) hb_xgrab( dwNumberOfBytesToRead + 1 );
and:
if( ! hb_storclen_buffer( lpBuffer, dwNumberOfBytesRead, 2 ) )
where I originally coded something like:
lpBuffer = ( char * ) hb_xgrab( dwNumberOfBytesToRead );
and:
hb_storclen(lpBuffer, NumberOfBytesRead, 2);
You said in the ChangeLog:
! Fixed buffer sizes, after valgrind test.
(off by one bugs. hb_storclen_buffer()/hb_retclen_buffer() need
one byte extra above the size returned, in order to hold the
EOS char)
The Clipper NG says:
Since _storclen() allows you to specify an explicit logical length for
the character value, the string you supply does not need to be
null-terminated and may safely contain embedded null bytes.
How come we need to allocate a buffer bigger by 1? Is it because you wanted to
use hb_storclen_buffer which does not need an hb_xfree and is a bit different
from hb_storclen?
Regards
Alex
_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour
