On Tue, 30 Jun 2009, Szak�ts Viktor wrote:

> I like these modifications :)

Anyhow it will force some 3-rd party code modifications.
I've just downloaded LETO and updated it for current Harbour SVN
code.
I'm attaching patch. Alexander please look at it.
I do not know LETO code so I haven't analyzed it and just simply
cleaned casting and fixed some problems reported by compiler
so you should look at it.
I haven't tried to pacify these warnings without your knowledge:

source/server/letofunc.c: In function ‘leto_UnlockAllRec’:
source/server/letofunc.c:1185: warning: ‘pArea’ may be used uninitialized in 
this function
source/server/letofunc.c:1197: warning: ‘pItem’ may be used uninitialized in 
this function
source/server/letofunc.c: In function ‘HB_FUN_LETO_PARSEFILTER’:
source/server/letofunc.c:585: warning: ‘bLastCond’ may be used uninitialized in 
this function
source/server/letofunc.c:591: warning: ‘cQuo’ may be used uninitialized in this 
function
source/server/letofunc.c: In function ‘leto_Scope’:
source/server/letofunc.c:2847: warning: ‘iKeyLen’ may be used uninitialized in 
this function
source/server/letofunc.c: In function ‘leto_Ordfunc’:
source/server/letofunc.c:3424: warning: ‘pTagPrev’ may be used uninitialized in 
this function
source/server/letofunc.c:3522: warning: ‘pTag’ may be used uninitialized in 
this function
source/server/letofunc.c: In function ‘leto_Seek’:
source/server/letofunc.c:2768: warning: ‘bSoftSeek’ may be used uninitialized 
in this function
source/server/letofunc.c:2768: warning: ‘bFindLast’ may be used uninitialized 
in this function
source/server/letofunc.c:2769: warning: ‘iKeyLen’ may be used uninitialized in 
this function
source/server/letofunc.c: In function ‘leto_UpdateRec’:
source/server/letofunc.c:2560: warning: ‘pData’ may be used uninitialized in 
this function
source/server/letofunc.c: In function ‘leto_Transaction’:
source/server/letofunc.c:4216: warning: ‘pData’ may be used uninitialized in 
this function

> One question: Do you plan to change color type in GT from int to
> anything else? If not, I'd like to change my local code to use ints
> (instead of BYTEs).

I wanted to leave int for future extension. In few function we also need
some value to indicate wrong color so we cannot use BYTE every where but
we have to use some wider type. Now -1 is used for it.
I'll try to look at GTAPI in this week.

best regards,
Przemek

Attachment: leto-cvs.diff.gz
Description: GNU Zip compressed data

_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to