Sounds very nice. One little comment: contrib\xpp shouldn't be on the source list as it's a contrib (and core shouldn't depend on contrib). Currently XPP_TBROWSE() is also defined in source/rtl/tbrowse.prg so it should be picked up already, I don't know why it isn't.
There were no comments on the list on FM_STAT/FM_NOSTAT, so I'll just remove them, since they have no use currently. After that, fm.c can be handled just like any other sources. For the #ifdef issue, I think it'd be best to replicate the active #ifs in source in the hbextern.ch. And make this option 'on' by default. so, for this source: --- #ifdef HB_COMPAT_C53 FUNC CLIPFUNC1 FUNC CLIPFUNC2 #ifdef HB_C52_UNDOC FUNC CLIPFUNC3U #endif #endif --- this would be generated (or '#if defined()' form): --- #ifdef HB_COMPAT_C53 EXTERNAL CLIPFUNC1 #endif #ifdef HB_COMPAT_C53 EXTERNAL CLIPFUNC2 #endif #ifdef HB_COMPAT_C53 #ifdef HB_C52_UNDOC EXTERNAL CLIPFUNC1 #endif #endif --- I don't want to take your free time, but the program could group symbols with identical #if protections, and dump them to source accordingly: --- #if defined( HB_COMPAT_C53 ) EXTERNAL CLIPFUNC1 EXTERNAL CLIPFUNC2 #endif #if defined( HB_COMPAT_C53 ) #if defined( HB_C52_UNDOC ) EXTERNAL CLIPFUNC1 #endif #endif --- Brgds, Viktor On Thu, Jun 25, 2009 at 2:42 AM, April White<april_wh...@sympatico.ca> wrote: > Viktor Szakáts wrote: >> >> ... >> Few issues which need to be solved to achieve that: >> - Add HB_CODEPAGE_* symbols (from source/codepage/*.c) > > Done >> >> - Add HB_LANG_* symbols (from source/lang/*.c) > > Done >> >> - Honor #if protections to keep source and hbextern.ch >> <http://hbextern.ch> in sync with each other. > > Work needed on C conditionals >> >> - Deleted FM_STAT, FM_NOSTAT (do we need these anyway?) > > Added fm.c to list of files to be skipped >> >> - Some classes are not picked, like XPP_TBROWSE. > > Added contrib\xpp to list of default dirs >> >> - Some wrong picks like WORKS in getsys.prg. >> (maybe some more) > > Hack to discard comment blocks, the source of this entry > > With these requirements the difference between the existing execution and my > 'custom' work is diminishing. > > April > > -- > We've crossed the thin line between genius and insanity. > > _______________________________________________ > Harbour mailing list > Harbour@harbour-project.org > http://lists.harbour-project.org/mailman/listinfo/harbour > _______________________________________________ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
