Should we change also hb_parvc() and hb_parvcx() ? Maybe it's better to solve the Clipper compatibility side in #define mappings, if possible, but for va parameters I don't know if that's possible.
Brgds, Viktor On Wed, Jun 24, 2009 at 10:15 PM, Viktor Szakáts<harbour...@syenar.hu> wrote: > Okay, I'm committing this, plus I've attached two files with > much more 'const's added, hbapifs.h and hbapigt.h. > > Pls review and I can also commit. > > Brgds, > Viktor > > On Wed, Jun 24, 2009 at 10:10 PM, Przemyslaw Czerpak<dru...@acn.waw.pl> wrote: >> On Wed, 24 Jun 2009, Szak�ts Viktor wrote: >>> Przemek, are you working on this now? >> >> I haven't started yet. >> >>> For a start, I'd like to change to these: >>> extern HB_EXPORT const char * hb_parc( int iParam ); >>> extern HB_EXPORT const char * hb_parcx( int iParam ); >>> extern HB_EXPORT const char * hb_itemGetCPtr( PHB_ITEM pItem ); >>> After that we can in parallel fix warnings (and errors). >> >> Please commit it. >> Tonight I'll try to check other public functions which may need commit. >> In few cases we can also add 'restrict' attribute (I added HB_RESTRICT >> to hbsetup.h for compilers which may not support C99 'restrict' keyword) >> It should help modern C/C++ compilers in code optimization. >> >>> Or, how to make this the most efficient? >> >> I do not now any other way then updating the code manually. After >> modifying header files warning messages can help us to locate >> places which should be updated. Not all because using casting we >> pacified some important warning messages but I hope we will locate >> such places later and updating them systematically. >> >> best regards, >> Przemek >> _______________________________________________ >> Harbour mailing list >> Harbour@harbour-project.org >> http://lists.harbour-project.org/mailman/listinfo/harbour >> > _______________________________________________ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
