Great. I think you can modify them all.
While PROCEDURE may give a very small performance benefit,
I think it's much cleaner to use METHOD keyword for METHODs.
Brgds,
Viktor
On 2009.06.19., at 14:08, April White wrote:
Viktor Szakáts wrote:
It probably works, but indeed looks a bit strange and not very
consistent with other code, so I think the answer is yes.
April Whgite
Before I make this change I believe I will alter the tool to find
these and report them, there are going to be many of them.
I'll post this list to the group first and then start the change
process. If the method has not return value I'll change it to
return self.
That did not take as long as I had expected:
Here is the list:
contrib\hbblat\blatcls.prg: PROCEDURE Check() CLASS HBBlat
contrib\hbgd\gdimage.prg: PROCEDURE Destruct() CLASS GDImage
contrib\xhb\hblog.prg: PROCEDURE Open() CLASS HB_Logger
contrib\xhb\hblog.prg: PROCEDURE Close() CLASS HB_Logger
contrib\xhb\hblog.prg: PROCEDURE Log( cMessage, nPriority ) CLASS
HB_Logger
contrib\xhb\hblog.prg: PROCEDURE Log( nStyle, cMessage, cName,
nPriority ) CLASS HB_LogChannel
contrib\xhb\hblog.prg: PROCEDURE Send( nStyle, cMessage, cName,
nPriority ) CLASS HB_LogConsole
contrib\xhb\hblog.prg: PROCEDURE Send( nStyle, cMessage, cName,
nPriority ) CLASS HB_LogDebug
contrib\xhb\stream.prg: PROCEDURE CopyTo( oTargetStream ) CLASS
TStream
contrib\xhb\stream.prg: PROCEDURE Finalize CLASS TStreamFileReader
contrib\xhb\stream.prg: PROCEDURE Finalize CLASS TStreamFileWriter
contrib\xhb\stream.prg: PROCEDURE WriteByte( cByte) CLASS
TStreamFileWriter
contrib\xhb\ttable.prg: PROCEDURE GET() CLASS HBRecord
contrib\xhb\ttable.prg: PROCEDURE Put() CLASS HBRecord
contrib\xhb\ttable.prg: PROCEDURE DBMove( nDirection ) CLASS HBTable
contrib\xhb\ttable.prg: PROCEDURE READ( lKeepBuffer ) CLASS HBTable
contrib\xhb\ttable.prg: PROCEDURE ReadBlank( lKeepBuffer ) CLASS
HBTable
contrib\xhb\ttable.prg: PROCEDURE AddField( f, t, l, d ) CLASS
HBTable
contrib\xhb\ttable.prg: PROCEDURE Gentable() CLASS HBTable
contrib\xhb\ttable.prg: PROCEDURE Create() CLASS HBOrder
Instead of returning self the safe solution seems to be to return
nothing as the procedure does.
April
--
All men are animals, some just make better pets.
_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour
_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour
